Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-12627178@ Fix outline on keyboard focus. #1536

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Nov 10, 2023

When editing a product in your cart, the "See full details" link does not have a proper keyboard focus indicator.
improper keyboard focus on link

This PR fixes that.
proper keyboard focus on link

Description

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

On both desktop and mobile:

  • Start dev server
  • Add item to cart
  • View cart
  • Edit line item
  • Hit tab until "See full details" receives focus
  • Full link should be outlined, rather than just dots in corners

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@wjhsf wjhsf requested a review from a team as a code owner November 10, 2023 21:22
@wjhsf wjhsf enabled auto-merge November 14, 2023 04:08
@wjhsf wjhsf merged commit 888052d into develop Nov 15, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants